Home Original page

[python-committers] New workflow - some questions

INADA Naoki songofacandy at gmail.com
Fri Jul 28 23:39:32 EDT 2017 
On Sat, Jul 29, 2017 at 7:30 AM, Mariatta Wijaya
<mariatta.wijaya at gmail.com> wrote:
>> 1. Section 32.2 in the Git bootcamp section - is there any reason to
>> use git at github URLs for the clones? I normally always use
>> https://github.com URLs, as they work with my proxy at work.
>
>
> I don't have any explanation other than Git bootcamp was initially written
> based on my personal setup.
> I cloned CPython using SSH, and that's what I wrote in the devguide :)
> You can use HTTPS if that works for you.
> Perhaps someone else can explain better the difference between cloning via
> HTTPS and SSH.
>

I usually uses https for "read-only" remote.
Sometimes, even I have commit rights, I use pull request from personal fork and
I don't want to push directly.
Of course, I can use https to push.  But it requires some additional
steps.  So it
prevent accidental push to "origin".

I think there are no downside to use HTTPS for "read only" remotes.

>
>> I generally use "Compare and create pull request"
>> from my clone's github page, as that seems simpler.
>
>
> Note that the link is only visible within 30 minutes (or so) after you
> pushed your branch to remote.
> If you did not create the PR immediately after pushing, the link disappears.
> In this case, the instructions in 32.10 will help (maybe?).
> Can we assume that people will create their PR immediately?
> Maybe an improvement is to mention the "Compare and create pull request",
> and to do this immediately after pushing the branch.
>
> side-topic: Does anyone have some sort of script/git
> alias/program/whatchamacallit that will open the PR page once we push to
> remote? (similar to what cherry_picker does)  That could be a time saver :)
>

I use Github's "hub" CLI.
https://github.com/github/hub

"hub pull-request" can be used to create pull request from terminal.
"hub browse" can be used to open browser for current branch.


Regards,
More information about the python-committers mailing list