Home Original page

[python-committers] Orphaned backports

Terry Reedy tjreedy at udel.edu
Sun Apr 22 14:27:16 EDT 2018 
On 4/22/2018 12:16 PM, Serhiy Storchaka wrote:
> miss-islington is an awesome bot! It makes fixing bugs in multiple 
> versions much simpler. You need just accept automatically created 
> backporting PRs.
> 
> But there is a downside. miss-islington makes the life so easier, that 
> sometimes you forgot about not finished backports. miss-islington can 
> fail to backport some changes for different reasons. Currently on GitHub 
> there are tens merged PRs labeled for backporting, but backports were 
> not finished. Please take attention if your PRs in one of the following 
> lists:

Does github allow repository owners to send email directly to people who 
have submitted PRs or at least, people with commit privileges (in this 
case, those whose have done particular merges)?

> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.7%22+is%3Aclosed 

> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Aclosed 

Several of these were closed without merging and should not and cannot 
be backported.  For instance, you closed
https://github.com/python/cpython/pull/4225
after you submitted and merged a replacement.
https://github.com/python/cpython/pull/6259

Stripping backport labels off of rejected PRs could be considered.  But 
this would toss information needed for a new PR if the bpo issue is 
open.  Expecting either the submitter or merged of a replacement to go 
back and clean up the original seems a bit much.  The submitter might 
not be able to, and the merger might not know or forget that the PR is a 
replacement.  Perhaps rejected PRs should just be ignored.

Replacing 'closed' with 'merged' excludes rejected PRs.

https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+3.6%22+is%3Amerged

> https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Aclosed 

https://github.com/python/cpython/pulls?q=label%3A%22needs+backport+to+2.7%22+is%3Amerged

The 2.7 backport of https://github.com/python/cpython/pull/3639
is yours.

tjr
More information about the python-committers mailing list