Home Original page

[python-committers] Auto-merge the backport PR with one core dev approval and all passing CI

Senthil Kumaran senthil at uthcode.com
Mon Feb 5 09:28:20 EST 2018 
I like to seek one clarification.

I know git has author as well as committer. I am assuming that even if
miss-islington backports the PR, the author'ship of the patch is still
preserved.

Is that correct?

Thank you,
Senthil



On Mon, Feb 5, 2018 at 6:18 AM, Senthil Kumaran <senthil at uthcode.com> wrote:

> Great idea. Definitely, +1.
>
> On Mon, Feb 5, 2018 at 6:07 AM, Mariatta Wijaya <mariatta.wijaya at gmail.com
> > wrote:
>
>> Hi,
>>
>> I will have some time in the next couple weeks to work on miss-islington.
>> I'm thinking to work on this issue: https://github.com/pyth
>> on/miss-islington/issues/44
>>
>> The idea is to have miss-islington automatically merge the backport PR,
>> after all CI passed and after a core dev approved the PR. I think this will
>> save us a lot of button clicks and time.
>>
>> Just wanted to check if everyone is pretty much +1 on this, before I
>> start writing the code.
>>
>> Some notes and implicationss:
>>
>> - The expectation is that the commit message has already been cleaned up
>> on the master branch
>> - It already knows how to replace the # to GH- in the commit message
>> - miss-islington will need write access to CPython
>> - git log it will show miss-islington (bot) as the committer
>> - If you still want to do the merge yourself, then just don't approve
>> miss-islington's PR.
>>
>> What does everyone here think about all that?
>>
>> Thanks.
>>
>> Mariatta Wijaya
>>
>> _______________________________________________
>> python-committers mailing list
>> python-committers at python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-committers/attachments/20180205/c390fac0/attachment-0001.html>
More information about the python-committers mailing list