Home Original page

[python-committers] Auto-merge the backport PR with one core dev approval and all passing CI

Nick Coghlan ncoghlan at gmail.com
Mon Feb 5 09:34:59 EST 2018 
On 6 February 2018 at 00:07, Mariatta Wijaya <mariatta.wijaya at gmail.com> wrote:
> Some notes and implicationss:
>
> - The expectation is that the commit message has already been cleaned up on
> the master branch
> - It already knows how to replace the # to GH- in the commit message
> - miss-islington will need write access to CPython
> - git log it will show miss-islington (bot) as the committer
> - If you still want to do the merge yourself, then just don't approve
> miss-islington's PR.
>
> What does everyone here think about all that?

+1 from me, as being able to do the backport PR reviews as soon as
Miss Islington creates them means I'll still have the original review
fresh in my mind. (I know I can theoretically do that now, but I
currently tend not to look at the details of the backport PRs until
the CI run is finished)

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia
More information about the python-committers mailing list