Home Original page

[python-committers] AppVeyor is now required to pass on PRs

Terry Reedy tjreedy at udel.edu
Thu Jan 25 15:27:17 EST 2018 
On 1/25/2018 1:52 PM, Brett Cannon wrote:
> 
> 
> On Wed, 24 Jan 2018 at 10:12 Victor Stinner <victor.stinner at gmail.com 
> <mailto:victor.stinner at gmail.com>> wrote:

>     AppVeyor usually takes between 30 min and 1 hour to check a PR,

Yesterday, AppVeyor surprised me by finishing in about 6 minutes, 
handily beating Travis.  I wonder whether this was a fluke, or if 
something changed somewhere.  Or was it the luck of no backlog.

> No one has spoken up so I guess everyone else is okay with the delay 
> ATM. My worry with flipping it off and trusting ourselves this close to 
> the beta is the last time I did that people didn't wait and we landed 
> breaking changes. So unless other people speak up that the delay is a 
> hindrance I'm inclined to leave it until we at least get past the beta.

Since I develop and test on Windows, I don't usually need the AppVeyor 
test*, but for patches developed on *nix, it is needed.

* Even then, there was one IDLE test change that interfered with another 
test, only on Windows.

Terry
More information about the python-committers mailing list