Home Original page

[python-committers] Wanting to merge my first PR under github

Mariatta Wijaya mariatta.wijaya at gmail.com
Wed Mar 21 10:02:34 EDT 2018 
Some steps were written here:
https://devguide.python.org/gitbootcamp/#accepting-and-merging-a-pull-request

And the section right after explains the backport.

I guess it needs reorganizing.

Top posted from my phone while literally on a beach.

On Wed, Mar 21, 2018, 7:57 AM Paul Moore <p.f.moore at gmail.com> wrote:

> On 21 March 2018 at 12:42, Nick Coghlan <ncoghlan at gmail.com> wrote:
> > On 21 March 2018 at 06:58, Paul Moore <p.f.moore at gmail.com> wrote:
> >>
> >> Hi,
> >> Cheryl Sabella kindly migrated a patch I'd put on bpo some time ago
> >> but forgotten about onto github. The PR (#6158) is ready to go (I
> >> think) but this is the first time since the migration to github that
> >> I've done a merge, and I'm not quite sure what the workflow is :-( I
> >> didn't see much in the devguide (which covers how to write a PR, how
> >> to test it etc, but not so much how to merge it, unless I missed
> >> something, or it's so simple that the little I did find is all that's
> >> needed!)
> >
> >
> > You didn't miss it - https://devguide.python.org/committing/ is still
> pretty
> > much written for the old approach of merging on the command line.
> >
> > So a devguide issue would definltely be appropriate, and if you're so
> > inclined, even a PR with the docs that you wish had existing when you
> looked
> > for them :)
>
> I'll certainly try to find some time to put something together. For
> now, I've raised https://github.com/python/devguide/issues/347 to
> track it.
>
> Paul
> _______________________________________________
> python-committers mailing list
> python-committers at python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-committers/attachments/20180321/3acb906c/attachment.html>
More information about the python-committers mailing list