Home Original page

[python-committers] Merge with spurious CI failures?

Gregory P. Smith greg at krypto.org
Wed May 8 13:06:53 EDT 2019 
fwiw a future way to avoid this mess is in
https://bugs.python.org/issue36855: have the tests support multiple
certificates so we can stage the new ones into our repo before updating the
server.

-gps

On Wed, May 8, 2019 at 11:15 AM Gregory P. Smith <greg at krypto.org> wrote:

> If this cert change is impacting CI checks for everyone's PRs, I suspect
> all PRs will need to merge this change into their branch before they can
> pass CI.
>
> Having CI depend on external network resources does not seem like a good
> idea.
>
> -gps
>
> On Wed, May 8, 2019 at 11:04 AM Antoine Pitrou <antoine at python.org> wrote:
>
>>
>> Ah, there's already a PR at
>> https://github.com/python/cpython/pull/13192, thanks to Gregory.
>>
>> Regards
>>
>> Antoine.
>>
>>
>> Le 08/05/2019 à 17:58, Antoine Pitrou a écrit :
>> >
>> > Ok, apparently the SSL cert on self-signed.pythontest.net was changed
>> > but it wasn't updated in our source tree, hence the failure.
>> >
>> > Regards
>> >
>> > Antoine.
>> >
>> >
>> > Le 08/05/2019 à 17:49, Mariatta a écrit :
>> >> If you can't merge from GitHub UI then you won't be able to do it from
>> >> GitHub command line (it respects the same branch protection policy)
>> >>
>> >> I don't think we should merge if tests are still failing. Perhaps the
>> >> test should be adjusted to handle this spurious errors? Can it be
>> marked
>> >> as "allowed failure" or something like that?
>> >>
>> >>
>> >> On Wed, May 8, 2019, 8:32 AM Antoine Pitrou <antoine at python.org
>> >> <mailto:antoine at python.org>> wrote:
>> >>
>> >>
>> >>     Hello,
>> >>
>> >>     There are spurious CI failures (SSL certificate issue in
>> test_httplib).
>> >>     Therefore the "Squash and merge" button is greyed out.
>> >>
>> >>     How should I merge? Using the command-line instructions from
>> Github?
>> >>
>> >>     Regards
>> >>
>> >>     Antoine.
>> >>     _______________________________________________
>> >>     python-committers mailing list
>> >>     python-committers at python.org <mailto:python-committers at python.org>
>> >>     https://mail.python.org/mailman/listinfo/python-committers
>> >>     Code of Conduct: https://www.python.org/psf/codeofconduct/
>> >>
>> > _______________________________________________
>> > python-committers mailing list
>> > python-committers at python.org
>> > https://mail.python.org/mailman/listinfo/python-committers
>> > Code of Conduct: https://www.python.org/psf/codeofconduct/
>> >
>> _______________________________________________
>> python-committers mailing list
>> python-committers at python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-committers/attachments/20190508/4e0e8e36/attachment-0001.html>
More information about the python-committers mailing list