Home Original page

[Python-Dev] Re: OS/2 EMX changes to dynload_shlib.c

Guido van Rossum guido@python.org
Wed, 27 Feb 2002 07:40:01 -0500 
> On Tue, 26 Feb 2002, Guido Van Rossum wrote:
> 
> > Given the number of OS/2 EMX specific changes to
> > dynload_shlib.c, wouldn't it be better to create a
> > separate dynload_os2.c?
> 
> Its just occurred to me that you might in fact be referring to the changes
> to import.c, which were in the same commit (& thus the same checkin
> message) and were extensive.  I did try to make it clear in the checkin
> message that changes to multiple files were committed.
> 
> It seems to be de rigeur to commit a single file at a time; something I
> hadn't appreciated and don't remember being advised about.  I will follow
> this practive from now on.

No need -- you're right, I mistook the diff, but that's purely my
fault.  Multi-file commits are quite common when they're related.

--Guido van Rossum (home page: http://www.python.org/~guido/)