"Martin v. Löwis" martin at v.loewis.de
Fri Feb 10 22:33:28 CET 2006

• Previous message: [Python-Dev] Pervasive socket failures on Windows
• Next message: [Python-Dev] Pervasive socket failures on Windows
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Tim Peters wrote:
> I suggest skipping the new crud conditionalized on a symbol like
> 
>     Py_SOCKET_FD_CAN_BE_GE_FD_SETSIZE
> 

Hmm... How about this patch:

Index: Modules/socketmodule.c
===================================================================
--- Modules/socketmodule.c      (Revision 42308)
+++ Modules/socketmodule.c      (Arbeitskopie)
@@ -396,7 +396,14 @@
 static PyTypeObject sock_type;

 /* Can we call select() with this socket without a buffer overrun? */
+#ifdef MS_WINDOWS
+/* Everything is selectable on Windows */
+#define IS_SELECTABLE(s)  1
+#else
+/* POSIX says selecting descriptors above FD_SETSIZE is undefined
+   behaviour. */
 #define IS_SELECTABLE(s) ((s)->sock_fd < FD_SETSIZE)
+#endif

 static PyObject*
 select_error(void)

Regards,
Martin

---

• Previous message: [Python-Dev] Pervasive socket failures on Windows
• Next message: [Python-Dev] Pervasive socket failures on Windows
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Python-Dev mailing list