Home Original page

[Python-Dev] Anyone can do patch reviews

Tres Seaver tseaver at palladion.com
Tue Apr 27 23:21:39 CEST 2010 
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin v. Löwis wrote:
>> Hmm, it feels exactly the other way around to me:  working with the DVCS
>> tools while reviewiing a patch allows me to be more productive (e.g.,
>> using 'bzr shelve' or the equivalent hg subcommand).
> 
> Just try using Subversion for some time again, and you'll see that it is
> not difficult at all. Start with a clean sandbox, then apply the patch.
> If you want to go back to the state without patch, revert the sandbox,
> if you need it again, apply it again. It's really simple.

I use Subversion daily as a committer on multiple projects.  Keeping
multiple readon-only checkouts around to evaluate patches is much
clunkier than maintaining DVCS branches for the same purpose.

As a non-committer, what I would miss most is the ability to make local
commits.  Features like "shelve", "log -p", etc., are aslo extremely
useful when analyzing a patch.


Tres.
- --
===================================================================
Tres Seaver          +1 540-429-0999          tseaver at palladion.com
Palladion Software   "Excellence by Design"    http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkvXVV8ACgkQ+gerLs4ltQ7JqwCfVZPkm8/3XUuuzpm/N+08x2RI
KWYAn004cLJS3poYZ/4BvSFOGzMpwNuC
=j3lH
-----END PGP SIGNATURE-----
More information about the Python-Dev mailing list