Antoine Pitrou solipsis at pitrou.net
Tue Mar 8 14:19:28 CET 2011

• Previous message: [Python-Dev] v2.7 tag
• Next message: [Python-Dev] hooks: Add roundup integration hook.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Tue, 08 Mar 2011 12:23:54 +0100
local <python-checkins at python.org> wrote:
> +
> +VERBS = r'(?:\b(?P<verb>close[sd]?|closing|fixe[sd]|fixing|fix)\s+)?'
> +ISSUE_PATTERN = re.compile(r'%s(?:#|\bissue|\bbug)\s*(?P<issue_id>[0-9]+)'
> +                           % VERBS, re.I)

This should only match numbers with 4 and 5 figures IMO.
Otherwise things like "this is priority #1" in commit messages will
spam issue number 1 (assuming it exists).

Also, I'm not sure trying to match too many verbs is useful. Things are
clearer and more predictible if we mandate a single form, perhaps only
at the last line of the commit message. We don't want false positives
(such as messages about closed files, etc.).

Regards

Antoine.

---

• Previous message: [Python-Dev] v2.7 tag
• Next message: [Python-Dev] hooks: Add roundup integration hook.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Python-Dev mailing list