Home Original page

[Python-Dev] patch metadata - to use or not to use?

Antoine Pitrou solipsis at pitrou.net
Sat Nov 19 10:51:49 CET 2011 
On Sat, 19 Nov 2011 09:42:49 +0100
Stefan Behnel <stefan_ml at behnel.de> wrote:
> Hi,
> 
> I recently got some patches accepted for inclusion in 3.3, and each time, 
> the patch metadata (such as my name and my commit comment) were stripped by 
> applying the patch manually, instead of hg importing it. This makes it 
> clear in the history who eventually reviewed and applied the patch, but 
> less visible who wrote it (except for the entry in Misc/NEWS).
> 
> I didn't see this mentioned in the dev-guide. Is it being considered the 
> Right Way To Do It?

It is common to add minor things to the patch when committing (such as a
redacted NEWS entry, or a ACKS entry), in which cases you can't import
it anyway. Often the name of the contributor is added to NEWS *and* to
the commit message.

Regards

Antoine.
More information about the Python-Dev mailing list