Home Original page

[Python-Dev] cpython (3.2): adjust braces a bit

Benjamin Peterson benjamin at python.org
Fri Oct 21 19:16:59 CEST 2011 
2011/10/21 Tres Seaver <tseaver at palladion.com>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 10/21/2011 12:31 PM, Benjamin Peterson wrote:
>> 2011/10/21 Eric V. Smith <eric at trueblade.com>:
>>> What's the logic for adding some braces, but removing others?
>>
>> No braces if everything is a one-liner, otherwise braces
>> everywhere.
>
> Hmm, PEP 7 doesn't show any example of the one-liner exception.  Given
> that it tends to promote errors, particularly among
> indentation-conditioned Python programmers (adding another statement
> at the same indentation level), why not just have braces everywhere?

It certainly doesn't explicitly but

	if (type->tp_dictoffset != 0 && base->tp_dictoffset == 0 &&
	    type->tp_dictoffset == b_size &&
	    (size_t)t_size == b_size + sizeof(PyObject *))
	    return 0; /* "Forgive" adding a __dict__ only */


-- 
Regards,
Benjamin
More information about the Python-Dev mailing list