Home Original page

[Python-Dev] test___all__ polluting sys.modules?

Benjamin Peterson benjamin at python.org
Sun Dec 30 01:46:39 CET 2012 
2012/12/29 Eli Bendersky <eliben at gmail.com>:
> Hi,
>
> This came up while investigating some test-order-dependency failures in
> issue 16076.
>
> test___all__ goes over modules that have `__all__` in them and does 'from
> <module> import *' on them. This leaves a lot of modules in sys.modules,
> which may interfere with some tests that do fancy things with sys,modules.
> In particular, the ElementTree tests have trouble with it because they
> carefully set up the imports to get the C or the Python version of etree
> (see issues 15083 and 15075).
>
> Would it make sense to save the sys.modules state and restore it in
> test___all__ so that sys.modules isn't affected by this test?

Sounds reasonable to me.

-- 
Regards,
Benjamin
More information about the Python-Dev mailing list