Georg Brandl g.brandl at gmx.net
Wed Mar 14 21:52:44 CET 2012

• Previous message: [Python-Dev] [Python-checkins] cpython: PEP 417: Adding unittest.mock
• Next message: [Python-Dev] 2012 Language Summit Report (updated, included here)
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On 14.03.2012 21:46, andrew.svetlov wrote:

> diff --git a/Lib/idlelib/rpc.py b/Lib/idlelib/rpc.py
> --- a/Lib/idlelib/rpc.py
> +++ b/Lib/idlelib/rpc.py
> @@ -196,8 +196,12 @@
>                   return ("ERROR", "Unsupported message type: %s" % how)
>           except SystemExit:
>               raise
> +        except KeyboardInterrupt:
> +            raise
>           except socket.error:
>               raise
> +        except Exception as ex:
> +            return ("CALLEXC", ex)
>           except:
>               msg = "*** Internal Error: rpc.py:SocketIO.localcall()\n\n"\
>                     " Object: %s \n Method: %s \n Args: %s\n"

It appears that this would be better written as

except socket.error:
     raise
except Exception:
     return ("CALLEXC", ex)
except:  # BaseException, i.e. SystemExit, KeyboardInterrupt, GeneratorExit
     raise

Georg

---

• Previous message: [Python-Dev] [Python-checkins] cpython: PEP 417: Adding unittest.mock
• Next message: [Python-Dev] 2012 Language Summit Report (updated, included here)
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Python-Dev mailing list