Oleg Broytman phd at phdru.name
Mon Feb 11 13:37:35 CET 2013

• Previous message: [Python-Dev] Question regarding: Lib/_markupbase.py
• Next message: [Python-Dev] Question regarding: Lib/_markupbase.py
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Mon, Feb 11, 2013 at 12:16:48PM +0000, Developer Developer <just_another_developer at yahoo.de> wrote:
> I was having a look at the file: Lib/_markupbase.py (@ 82151), function: "_parse_doctype_element" and have seen something that has caught my attention:
> 
> if '>' in rawdata[j:]:
>     return rawdata.find(">", j) + 1
> 
> 
> Wouldn't it be better to do the following?
> pos = rawdata.find(">", j)
> if pos != -1:
>     return pos + 1
> 
> Otherwise I think we are scanning rawdata[j:] twice.

   Is it really a significant optimization? Can you do an experiment and
show figures?

Oleg.
-- 
     Oleg Broytman            http://phdru.name/            phd at phdru.name
           Programmers don't die, they just GOSUB without RETURN.

---

• Previous message: [Python-Dev] Question regarding: Lib/_markupbase.py
• Next message: [Python-Dev] Question regarding: Lib/_markupbase.py
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Python-Dev mailing list