A.M. Kuchling amk at amk.ca
Mon Nov 11 03:30:02 CET 2013

• Previous message: [Python-Dev] [RELEASE] Python 2.7.6
• Next message: [Python-Dev] PEP 454 (tracemalloc) close to pronouncement
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Sun, Nov 10, 2013 at 06:48:30PM -0500, Terry Reedy wrote:
> >+    def encode(self,input,errors='strict'):
> >+        return codecs.charmap_encode(input,errors,encoding_table)
>
> You left out the spaces after the call commas (PEP8)

Thanks for noting this.  This file is programmatically generated by
the scripts in Tools/unicode/ .  Many of the files in this directory
also have similar PEP8 violations:

grep -r 'def encode' Lib/encodings/ |grep ',inpu' |less
...
Lib/encodings//koi8_r.py:    def encode(self,input,errors='strict'):
Lib/encodings//koi8_u.py:    def encode(self,input,errors='strict'):
Lib/encodings//mac_arabic.py:    def encode(self,input,errors='strict'):
Lib/encodings//mac_centeuro.py:    def encode(self,input,errors='strict'):

So I'll take a look at fixing the code generator to generate properly
formatted code, but it probably isn't worth modifying all of the
existing files in Lib/encodings.

--amk

---

• Previous message: [Python-Dev] [RELEASE] Python 2.7.6
• Next message: [Python-Dev] PEP 454 (tracemalloc) close to pronouncement
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Python-Dev mailing list