Home Original page

[Python-Dev] Commit-ready patches needing review

Nikolaus Rath Nikolaus at rath.org
Mon Apr 28 00:42:10 CEST 2014 
Antoine Pitrou <solipsis at pitrou.net> writes:
> On Sun, 27 Apr 2014 12:10:46 -0700
> Nikolaus Rath <Nikolaus at rath.org> wrote:
>> 
>> * http://bugs.python.org/issue20951 (SSLSocket.send() returns 0 for
>>   non-blocking socket)
>> 
>>   In this case someone just needs to decide if we want to (a) document
>>   the current behavior, (b) deprecate the current behavior or (c) change
>>   the current behavior. I have attached patches for (a) and (b), and if
>>   (c) is the desired route I'll be happy to create a patch on short
>>   notice.
>
> In this case I'd be inclined to follow Ben Darnell's advice and change
> the current behaviour (i.e., let the exception bubble up rather than
> catch it). This is what your initial patch does. However, it would need
> a documentation addition to explain the change (and perhaps a test,
> though that doesn't seem terribly necessary here).

Sounds good to me. I just attached an updated patch to the issue.


Thanks for looking at this!


Best,
-Nikolaus

-- 
GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«
More information about the Python-Dev mailing list