Home Original page

[Python-Dev] cpython: Issue #22003: When initialized from a bytes object, io.BytesIO() now

Antoine Pitrou antoine at python.org
Wed Jul 30 23:23:25 CEST 2014 
Le 30/07/2014 15:48, Serhiy Storchaka a écrit :
>
> Ignoring tests and comments my patch adds/removes/modifies about 200
> lines, and David's patch -- about 150 lines of code. But it's __sizeof__
> looks not correct, correcting it requires changing about 50 lines. In
> sum the complexity of both patches is about equal.

I meant that David's approach is conceptually simpler, which makes it 
easier to review.
Regardless, there is no exclusive-OR here: if you can improve over the 
current version, there's no reason not to consider it/

> I didn't look at David's patch too close yet. But my patch includes
> optimization for end-of-line scanning.

Ahah, unrelated stuff :-)
More information about the Python-Dev mailing list