Home Original page

[Python-Dev] [Python-checkins] cpython: Fixes test_getargs2 to get the buildbots working again.

Steve Dower steve.dower at python.org
Sun Sep 11 22:48:15 EDT 2016 
On 11Sep2016 1944, steve.dower wrote:
> https://hg.python.org/cpython/rev/7793d34609cb
> changeset:   103679:7793d34609cb
> user:        Steve Dower <steve.dower at microsoft.com>
> date:        Sun Sep 11 19:43:51 2016 -0700
> summary:
>   Fixes test_getargs2 to get the buildbots working again.
>
> files:
>   Lib/test/test_getargs2.py |  2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/Lib/test/test_getargs2.py b/Lib/test/test_getargs2.py
> --- a/Lib/test/test_getargs2.py
> +++ b/Lib/test/test_getargs2.py
> @@ -471,7 +471,7 @@
>
>          ret = get_args(*TupleSubclass([1, 2]))
>          self.assertEqual(ret, (1, 2))
> -        self.assertIs(type(ret), tuple)
> +        self.assertIsInstance(ret, tuple)
>
>          ret = get_args()
>          self.assertIn(ret, ((), None))

I'm not sure this is the fix we want to keep here, but it was sufficient 
to get the test going and unblock all the buildbots.

I'm not entirely sure when the break appeared (essentially we seem to 
not be copying *args into a new tuple), but I'd guess it's to do with 
the fast calling improvements.

Cheers,
Steve
More information about the Python-Dev mailing list