Barry Warsaw barry at python.org
Mon Sep 11 21:49:03 EDT 2017

• Previous message (by thread): [Python-Dev] PEP 557: Data Classes
• Next message (by thread): [Python-Dev] PEP 557: Data Classes
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Sep 11, 2017, at 18:36, Eric V. Smith <eric at trueblade.com> wrote:
> So if we don't do enums, I think the choices are ints, strs, or maybe True/False/None. Do you have a preference here?
> 
> If int or str, I assume we'd want module-level constants.
> 
> I like the name compare=, and 3 values makes sense: None, Equality, Ordered.

+1 for the name, the 3 values, and making them module constants.  After that, I don’t think it really matters what their implementation is.  User code will look the same either way.  One minor nice effect of using an enum is that the dataclass function can use `is` instead of `==` to compare keyword argument values.

-Barry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://mail.python.org/pipermail/python-dev/attachments/20170911/b5671831/attachment.sig>

---

• Previous message (by thread): [Python-Dev] PEP 557: Data Classes
• Next message (by thread): [Python-Dev] PEP 557: Data Classes
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Python-Dev mailing list