Home Original page

[Python-Dev] Policy on refactoring/clean up

Antoine Pitrou solipsis at pitrou.net
Tue Jun 26 08:12:13 EDT 2018 
On Tue, 26 Jun 2018 11:00:48 +0200
Jeroen Demeyer <J.Demeyer at UGent.be> wrote:
> Hello,
> 
> On https://github.com/python/cpython/pull/7909 I encountered friction 
> for a PR which I expected to be uncontroversial: it just moves some code 
> without changing any functionality.
> 
> So basically my question is: is there some CPython policy *against* 
> refactoring code to make it easier to read and write? (Note that I'm not 
> talking about pure style issues here)

I think refactorings are generally ok, assuming they bring a
substantial maintainability or readability benefit.  I haven't studied
your PR enough to decide whether that's the case for the changes you
are proposing, though.

Regards

Antoine.
More information about the Python-Dev mailing list