fix: Using alg=none header for custom tokens in emulator mode by hiranya911 · Pull Request #541 · firebase/firebase-admin-python

Conversation

@hiranya911

Setting the alg header to none when creating custom tokens for the emulator. This requires a recent bug fix in the google-auth package: googleapis/google-auth-library-python#729

To enable that I'm also upgrading the corresponding dependencies.

@hiranya911

@hiranya911

Tried to work around that issue in the tests, but it's not quite working out. Turns out google-cloud-firestore has also dropped Python 3.5 support as of their v2 release. I think we have to just drop Python 3.5 support before we can go ahead.

@lahirumaramba FYA

@hiranya911

Rebased on the head of main branch.

lahirumaramba

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Labels

2 participants

@hiranya911 @lahirumaramba