chore: Upgraded Google Auth, Cloud Firestore, and Cloud Storage dependencies by lahirumaramba · Pull Request #544 · firebase/firebase-admin-python
Conversation
- Upgraded Auth, Firestore, and Storage versions
RELEASE NOTE: Upgraded google-cloud-firestore dependency version to to 2.1.0.
RELEASE NOTE: Upgraded google-cloud-storage dependency version to 1.37.1.
RELEASE NOTE: Upgraded google-api-core dependency version to 1.22.1.
Note: Staging to trigger integration tests
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Just one change needed.
| google-auth == 1.18.0 # temporary workaround | ||
| google-cloud-firestore >= 1.4.0; platform.python_implementation != 'PyPy' | ||
| google-cloud-storage >= 1.18.0 | ||
| google-auth == 1.28.1 |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can now drop this altogether, and let it be transitively installed. (temp workaround was to pin it at an old version)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! removed the google-auth dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters