Remove optional from two member variables by Sineaggi · Pull Request #1550 · gitpython-developers/GitPython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could you also add an assertion of the working_tree_dir for completeness? It's easy to confuse both which is what I did apparently. The working_dir is the CWD of the git repository, either the working_tree_dir or the git_dir, which I think should be an assertion for the bare and non-bare cases.
If that assertion holds, of course, I was going by the docs.
