Fix ed25519 key type in ca_util by rculpepper · Pull Request #27093 · hashicorp/vault

@rculpepper

This PR is to address the error described in issue #26089 with ed25519 keys

@rculpepper

@rculpepper

@github-actions

CI Results:
All Go tests succeeded! ✅

@github-actions

Build Results:
All builds succeeded! ✅

victorr

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Is there maybe a unit test we can augment to cover this case?

@stevendpclark

Unit test would be welcome, there's also a similar error within GetPrivateKeyTypeFromPublicKey.

Would you mind addressing that one as well as part of this? Also what are your thoughts on just adding both the pointer and non-pointer types to all the case statements?

@rculpepper

@rculpepper

@rculpepper

Also what are your thoughts on just adding both the pointer and non-pointer types to all the case statements?

I don't have a problem with it, but I don't know how useful it would be. I don't see anywhere that we expect an ed25519 key to be a pointer (except the case here)

@rculpepper

stevendpclark

@@ -0,0 +1,3 @@
```release-note:bug
pki: Fix error in cross-signing using ed25519 keys

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pki: Fix error in cross-signing using ed25519 keys
secrets/pki: Fix error in cross-signing using ed25519 keys

stevendpclark

@stevendpclark

I don't have a problem with it, but I don't know how useful it would be. I don't see anywhere that we expect an ed25519 key to be a pointer (except the case here)

Fair, lets not bother for now.

This was referenced

May 22, 2024