Fix ASI after get/set keyword by rbuckton · Pull Request #60225 · microsoft/TypeScript
@jakebailey
The results of the perf run you requested are in!
Here they are:
tsc
Comparison Report - baseline..pr| Metric | baseline | pr | Delta | Best | Worst | p-value |
|---|---|---|---|---|---|---|
| Compiler-Unions - node (v18.15.0, x64) | ||||||
| Errors | 31 | 31 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 62,340 | 62,340 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 50,379 | 50,379 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 194,618k (± 0.98%) | 195,887k (± 0.74%) | ~ | 192,920k | 196,500k | p=0.230 n=6 |
| Parse Time | 1.59s (± 1.69%) | 1.59s (± 1.36%) | ~ | 1.56s | 1.62s | p=0.744 n=6 |
| Bind Time | 0.87s (± 0.94%) | 0.87s (± 1.19%) | ~ | 0.85s | 0.88s | p=0.932 n=6 |
| Check Time | 11.72s (± 0.36%) | 11.73s (± 0.43%) | ~ | 11.66s | 11.81s | p=0.747 n=6 |
| Emit Time | 3.41s (± 4.33%) | 3.29s (± 0.71%) | ~ | 3.27s | 3.32s | p=0.085 n=6 |
| Total Time | 17.58s (± 0.71%) | 17.48s (± 0.33%) | ~ | 17.39s | 17.55s | p=0.173 n=6 |
| angular-1 - node (v18.15.0, x64) | ||||||
| Errors | 33 | 33 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 947,886 | 947,886 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 410,840 | 410,840 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 1,224,832k (± 0.00%) | 1,224,800k (± 0.00%) | ~ | 1,224,744k | 1,224,905k | p=0.128 n=6 |
| Parse Time | 8.10s (± 0.46%) | 8.09s (± 0.72%) | ~ | 8.01s | 8.14s | p=1.000 n=6 |
| Bind Time | 2.27s (± 0.79%) | 2.27s (± 1.20%) | ~ | 2.24s | 2.31s | p=1.000 n=6 |
| Check Time | 37.91s (± 0.48%) | 37.83s (± 0.65%) | ~ | 37.64s | 38.17s | p=0.572 n=6 |
| Emit Time | 18.27s (± 0.46%) | 18.31s (± 0.44%) | ~ | 18.19s | 18.43s | p=0.470 n=6 |
| Total Time | 66.55s (± 0.32%) | 66.50s (± 0.27%) | ~ | 66.35s | 66.81s | p=0.573 n=6 |
| mui-docs - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 2,530,075 | 2,530,075 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 916,374 | 916,374 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 2,341,564k (± 0.00%) | 2,341,588k (± 0.00%) | ~ | 2,341,455k | 2,341,662k | p=0.810 n=6 |
| Parse Time | 11.24s (± 0.34%) | 11.21s (± 0.48%) | ~ | 11.14s | 11.28s | p=0.520 n=6 |
| Bind Time | 2.63s (± 0.65%) | 2.62s (± 1.12%) | ~ | 2.58s | 2.66s | p=0.870 n=6 |
| Check Time | 91.80s (± 1.43%) | 90.82s (± 0.59%) | ~ | 90.29s | 91.74s | p=0.127 n=6 |
| Emit Time | 0.35s (± 1.81%) | 0.35s (± 4.04%) | ~ | 0.33s | 0.37s | p=1.000 n=6 |
| Total Time | 106.02s (± 1.25%) | 105.01s (± 0.50%) | ~ | 104.48s | 105.88s | p=0.128 n=6 |
| self-build-src - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 1,258,124 | 1,258,125 | +1 (+ 0.00%) | ~ | ~ | p=0.001 n=6 |
| Types | 266,266 | 266,267 | +1 (+ 0.00%) | ~ | ~ | p=0.001 n=6 |
| Memory used | 3,146,252k (± 0.02%) | 3,146,518k (± 0.02%) | ~ | 3,145,948k | 3,147,485k | p=0.689 n=6 |
| Parse Time | 6.61s (± 1.06%) | 6.59s (± 0.94%) | ~ | 6.52s | 6.70s | p=1.000 n=6 |
| Bind Time | 2.26s (± 4.21%) | 2.28s (± 5.57%) | ~ | 2.02s | 2.35s | p=0.376 n=6 |
| Check Time | 42.96s (± 0.52%) | 42.97s (± 0.21%) | ~ | 42.90s | 43.10s | p=0.575 n=6 |
| Emit Time | 3.53s (± 2.44%) | 3.48s (± 2.27%) | ~ | 3.38s | 3.56s | p=0.378 n=6 |
| Total Time | 55.37s (± 0.56%) | 55.31s (± 0.39%) | ~ | 55.03s | 55.56s | p=0.689 n=6 |
| self-build-src-public-api - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 1,258,124 | 1,258,125 | +1 (+ 0.00%) | ~ | ~ | p=0.001 n=6 |
| Types | 266,266 | 266,267 | +1 (+ 0.00%) | ~ | ~ | p=0.001 n=6 |
| Memory used | 2,619,761k (±11.18%) | 2,619,332k (±11.19%) | ~ | 2,498,271k | 3,218,166k | p=0.810 n=6 |
| Parse Time | 6.55s (± 1.45%) | 6.62s (± 1.99%) | ~ | 6.54s | 6.88s | p=0.127 n=6 |
| Bind Time | 2.19s (± 4.03%) | 2.16s (± 1.93%) | ~ | 2.09s | 2.20s | p=1.000 n=6 |
| Check Time | 43.02s (± 0.32%) | 43.10s (± 0.46%) | ~ | 42.85s | 43.34s | p=0.423 n=6 |
| Emit Time | 3.50s (± 1.89%) | 3.54s (± 1.08%) | ~ | 3.47s | 3.58s | p=0.230 n=6 |
| Total Time | 55.28s (± 0.47%) | 55.40s (± 0.39%) | ~ | 55.08s | 55.62s | p=0.378 n=6 |
| self-compiler - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 261,789 | 261,790 | +1 (+ 0.00%) | ~ | ~ | p=0.001 n=6 |
| Types | 106,508 | 106,509 | +1 (+ 0.00%) | ~ | ~ | p=0.001 n=6 |
| Memory used | 438,734k (± 0.01%) | 438,777k (± 0.02%) | ~ | 438,644k | 438,856k | p=0.575 n=6 |
| Parse Time | 4.40s (± 0.85%) | 4.40s (± 1.47%) | ~ | 4.32s | 4.47s | p=0.746 n=6 |
| Bind Time | 1.62s (± 0.91%) | 1.63s (± 1.14%) | ~ | 1.60s | 1.65s | p=0.463 n=6 |
| Check Time | 23.39s (± 0.47%) | 23.35s (± 0.16%) | ~ | 23.31s | 23.40s | p=0.809 n=6 |
| Emit Time | 1.91s (± 1.60%) | 1.92s (± 1.63%) | ~ | 1.87s | 1.96s | p=0.569 n=6 |
| Total Time | 31.31s (± 0.27%) | 31.29s (± 0.28%) | ~ | 31.17s | 31.36s | p=0.810 n=6 |
| ts-pre-modules - node (v18.15.0, x64) | ||||||
| Errors | 68 | 68 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 225,919 | 225,919 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 94,415 | 94,415 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 371,049k (± 0.01%) | 371,105k (± 0.01%) | ~ | 371,065k | 371,171k | p=0.065 n=6 |
| Parse Time | 3.60s (± 1.23%) | 3.62s (± 1.23%) | ~ | 3.57s | 3.69s | p=0.688 n=6 |
| Bind Time | 1.95s (± 0.90%) | 1.95s (± 1.57%) | ~ | 1.92s | 2.00s | p=0.870 n=6 |
| Check Time | 20.30s (± 0.55%) | 20.33s (± 0.40%) | ~ | 20.22s | 20.42s | p=0.873 n=6 |
| Emit Time | 0.00s | 0.00s | ~ | ~ | ~ | p=1.000 n=6 |
| Total Time | 25.86s (± 0.50%) | 25.90s (± 0.41%) | ~ | 25.79s | 26.04s | p=0.423 n=6 |
| vscode - node (v18.15.0, x64) | ||||||
| Errors | 3 | 3 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 3,120,850 | 3,120,850 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 1,075,428 | 1,075,428 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 3,213,118k (± 0.01%) | 3,213,374k (± 0.01%) | ~ | 3,212,827k | 3,213,614k | p=0.230 n=6 |
| Parse Time | 14.07s (± 0.37%) | 14.10s (± 0.45%) | ~ | 14.04s | 14.18s | p=0.747 n=6 |
| Bind Time | 4.47s (± 2.22%) | 4.45s (± 0.63%) | ~ | 4.43s | 4.50s | p=0.870 n=6 |
| Check Time | 86.93s (± 1.35%) | 87.35s (± 3.15%) | ~ | 85.10s | 92.35s | p=0.936 n=6 |
| Emit Time | 26.29s (± 4.15%) | 23.59s (± 7.19%) | 🟩-2.70s (-10.27%) | 22.66s | 26.95s | p=0.025 n=6 |
| Total Time | 131.76s (± 1.66%) | 129.48s (± 2.35%) | ~ | 126.40s | 133.69s | p=0.230 n=6 |
| webpack - node (v18.15.0, x64) | ||||||
| Errors | 0 | 0 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 285,279 | 285,279 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 115,798 | 115,798 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 435,603k (± 0.03%) | 435,677k (± 0.01%) | ~ | 435,598k | 435,745k | p=0.378 n=6 |
| Parse Time | 4.05s (± 1.60%) | 4.06s (± 0.83%) | ~ | 4.00s | 4.10s | p=0.520 n=6 |
| Bind Time | 1.75s (± 1.92%) | 1.76s (± 1.41%) | ~ | 1.73s | 1.80s | p=1.000 n=6 |
| Check Time | 18.40s (± 0.71%) | 18.43s (± 0.27%) | ~ | 18.35s | 18.48s | p=0.376 n=6 |
| Emit Time | 0.00s | 0.00s | ~ | ~ | ~ | p=1.000 n=6 |
| Total Time | 24.20s (± 0.46%) | 24.25s (± 0.28%) | ~ | 24.15s | 24.32s | p=0.196 n=6 |
| xstate-main - node (v18.15.0, x64) | ||||||
| Errors | 3 | 3 | ~ | ~ | ~ | p=1.000 n=6 |
| Symbols | 540,222 | 540,222 | ~ | ~ | ~ | p=1.000 n=6 |
| Types | 181,145 | 181,145 | ~ | ~ | ~ | p=1.000 n=6 |
| Memory used | 483,811k (± 0.01%) | 483,833k (± 0.01%) | ~ | 483,773k | 483,939k | p=0.936 n=6 |
| Parse Time | 2.72s (± 0.30%) | 2.73s (± 0.38%) | ~ | 2.71s | 2.74s | p=0.437 n=6 |
| Bind Time | 0.97s (± 0.78%) | 0.97s (± 0.42%) | ~ | 0.96s | 0.97s | p=1.000 n=6 |
| Check Time | 15.95s (± 0.13%) | 16.00s (± 0.37%) | ~ | 15.93s | 16.09s | p=0.199 n=6 |
| Emit Time | 0.00s | 0.00s | ~ | ~ | ~ | p=1.000 n=6 |
| Total Time | 19.64s (± 0.10%) | 19.69s (± 0.31%) | ~ | 19.62s | 19.78s | p=0.226 n=6 |
System info unknown
Hosts
- node (v18.15.0, x64)
Scenarios
- Compiler-Unions - node (v18.15.0, x64)
- angular-1 - node (v18.15.0, x64)
- mui-docs - node (v18.15.0, x64)
- self-build-src - node (v18.15.0, x64)
- self-build-src-public-api - node (v18.15.0, x64)
- self-compiler - node (v18.15.0, x64)
- ts-pre-modules - node (v18.15.0, x64)
- vscode - node (v18.15.0, x64)
- webpack - node (v18.15.0, x64)
- xstate-main - node (v18.15.0, x64)
| Benchmark | Name | Iterations |
|---|---|---|
| Current | pr | 6 |
| Baseline | baseline | 6 |