PYTHON-4219 Prep for 4.6.2 Release by blink1073 · Pull Request #1530 · mongodb/mongo-python-driver

@blink1073

@blink1073

ShaneHarvey

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to backport the fix for PYTHON-4147.

from typing import Tuple, Union

version_tuple: Tuple[Union[int, str], ...] = (4, 6, 2, ".dev0")
version_tuple: Tuple[Union[int, str], ...] = (4, 6, 2, "")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we always remove the "".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


PyMongo 4.6.2 fixes the following bug:

- Python 3.12 thread error while using ``MongoClient()`` function.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use the same changelog entry that's in 4.7:

- Fixed a bug appearing in Python 3.12 where "RuntimeError: can't create new thread at interpreter shutdown"
  could be written to stderr when a MongoClient's thread starts as the python interpreter is shutting down.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@blink1073

@blink1073

ShaneHarvey

caseyclements

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm