Started annotating connections.pyi by Spider84pr · Pull Request #15395 · python/typeshed
Starting with a small commit - I want to look how the test will run.
This comment has been minimized.
This comment has been minimized.
I have marked this PR as draft - I will make more commits in next several days. If such thing is forbidden - please write - I will close.
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉
I have marked this PR as draft - I will make more commits in next several days. If such thing is forbidden - please write - I will close.
That's perfectly fine, and a good hint for us maintainers to ignore the PR for now. Thanks!
Sorry I was busy and cannot start work.
Can you give me a hint and tell - if function def dump_packet(data) requiring annotations?
It missing in currant release
Sorry I was busy and cannot start work. Can you give me a hint and tell - if function def dump_packet(data) requiring annotations? It missing in currant release
@Spider84pr Seeing that it's only imported from .protocol in .connections, I would recommend removing it from connections.pyi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters