Add support for mise.toml by hobbypunk90 · Pull Request #700 · ruby/setup-ruby
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, it looks good, just one small thing to address
| const rubyLine = toolVersions.split(/\r?\n/).filter(e => /^ruby\s/.test(e))[0] | ||
| rubyVersion = rubyLine.match(/^ruby\s+(.+)$/)[1] | ||
| console.log(`Using ${rubyVersion} as input from file .tool-versions`) | ||
| } else if (rubyVersion === 'mise.toml') { // Read from mise.toml |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://mise.jdx.dev/configuration.html has 6 possible locations 😅
Hopefully mise.toml is the most common one, I don't really want to logic to search all those.
So yeah, let's look for just mise.toml for now.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see, you are right 😅 especially the conf.d would be crap 😁