Nick Clifton nickc@redhat.com
Fri Oct 13 13:47:00 GMT 2000

• Previous message (by thread): luciano gemme
• Next message (by thread): patch for opcodes/cgen-dis.in
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi Gemme,

: I submit the change for objcopy utility as previously declared in a
: previous mail.

: I've already sent the copyright form properly signed

I am currently waiting to here from the FSF lawyers that the copyright
assignment has gone through.  Once it has I will consider applying
your patch.

Please note however, that there are a couple of problems with your
patch:

  * You did not include any ChangeLog entries for the files that you
    have modified.  These really should be included.

  * You have added documentation for the new command line switches to
    objcopy.1 (good) but you forgot to also add the documentation to
    binutils.texi (bad).

  * You have added a new command line switch --srec-forceS3 to only
    allow the generation of S3 srecords.  Really this switch should
    take an argument of the type of srecord that should be forced, ie
    --srec-force={1|2|3}.

Cheers
	Nick

---

• Previous message (by thread): luciano gemme
• Next message (by thread): patch for opcodes/cgen-dis.in
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list