Home Original page

unreviewed sparc64 patch

Geoff Keating geoffk@cygnus.com
Mon Oct 16 13:08:00 GMT 2000 
Could someone please look at this patch?  It's over a month old,
and required for proper sparc64 binutils operation under Solaris.

-- 
- Geoffrey Keating <geoffk@cygnus.com>

===File ~/patches/cygnus/sparc64-relative.patch=============
2000-08-30  Geoffrey Keating  <geoffk@cygnus.com>

	* elf64-sparc.c (sparc64_elf_relocate_section): Clear the location
	of a GOT reloc.

Index: elf64-sparc.c
===================================================================
RCS file: /cvs/cvsfiles/devo/bfd/elf64-sparc.c,v
retrieving revision 1.48.2.2
diff -c -r1.48.2.2 elf64-sparc.c
*** elf64-sparc.c	2000/08/14 20:06:33	1.48.2.2
--- elf64-sparc.c	2000/08/31 03:23:54
***************
*** 2356,2362 ****
  		off &= ~1;
  	      else
  		{
- 		  bfd_put_64 (output_bfd, relocation, sgot->contents + off);
  		  local_got_offsets[r_symndx] |= 1;
  
  		  if (info->shared)
--- 2356,2361 ----
***************
*** 2364,2369 ****
--- 2363,2375 ----
  		      asection *srelgot;
  		      Elf_Internal_Rela outrel;
  
+ 		      /* The Solaris 2.7 64-bit linker adds the contents
+ 			 of the location to the value of the reloc.
+ 			 Note this is different behaviour to the
+ 			 32-bit linker, which both adds the contents
+ 			 and ignores the addend.  So clear the location.  */
+ 		      bfd_put_64 (output_bfd, 0, sgot->contents + off);
+ 		      
  		      /* We need to generate a R_SPARC_RELATIVE reloc
  			 for the dynamic linker.  */
  		      srelgot = bfd_get_section_by_name(dynobj, ".rela.got");
***************
*** 2380,2385 ****
--- 2386,2393 ----
  						  + srelgot->reloc_count));
  		      ++srelgot->reloc_count;
  		    }
+ 		  else
+ 		    bfd_put_64 (output_bfd, relocation, sgot->contents + off);
  		}
  	      relocation = sgot->output_offset + off - got_base;
  	    }
============================================================
More information about the Binutils mailing list