Alan Modra amodra@bigpond.net.au
Mon Dec 17 19:32:00 GMT 2001

• Previous message (by thread): [RFA] Don't sort PT_NOTE sections.
• Next message (by thread): [RFA] Don't sort PT_NOTE sections.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Wed, Dec 12, 2001 at 01:17:15PM -0800, Michael Snyder wrote:
> 
>         asection **secpp;
>   
>         /* If elf_segment_map is not from map_sections_to_segments, the
> !          sections may not be correctly ordered.  NOTE: do not sort
> !          sections of type PT_NOTE.  */
> !       if (m->count > 1 && m->p_type != PT_NOTE)
>   	qsort (m->sections, (size_t) m->count, sizeof (asection *),
>   	       elf_sort_sections);

Your comment change adds no information not immediately obvious in the
code.  Also, I think it may be safer to restrict this change to core
files.  ie. do sort for elf_elfheader (abfd)->e_type != ET_CORE

Alan

---

• Previous message (by thread): [RFA] Don't sort PT_NOTE sections.
• Next message (by thread): [RFA] Don't sort PT_NOTE sections.
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list