Home Original page

Another PA GAS testsuite fix

Anders Norlander anorland@synergenix.se
Wed Dec 19 01:19:00 GMT 2001 
On Tue, 2001-12-18 at 18:11, Hans-Peter Nilsson wrote:
> On 18 Dec 2001, Nick Clifton wrote:
> > Note - you did not include incbin.dat in the patch submission...  Of
Oops, so I did.

> > course it is a binary file, but it could have been MIME encoded.
> (Not that incbin.dat looks particularly binary, but:)
> 
> Aren't we supposed to avoid binary "source" files.  What would
> update patches, like a binutils-2.11-2.12.diff.gz look like?

Hmm, yes that's a problem. The windres tests do it and I believe there
was a discussion about ASCII encoding the files and binifying them
when running the tests. The only problem I see is that this test would
fail on CRLF platforms (like cygwin text-mounts) since that would
change the "binary" source file.

Here's the patch + incbin.dat.

If it's ok, please commit.

-Anders

-------------- next part --------------
Index: incbin.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/incbin.d,v
retrieving revision 1.2
diff -u -p -r1.2 incbin.d
--- incbin.d	2001/12/08 02:11:00	1.2
+++ incbin.d	2001/12/19 08:42:06
@@ -1,17 +1,13 @@
 #as: -I$srcdir/$subdir
-#objdump: -s -j .data
+#objdump: -s -j .text
 #name: incbin
 
 # Test the incbin pseudo-op
 
 .*: .*
 
-Contents of section .data:
- 0000 202e6461 74610a20 2e696e63 62696e20   .data. .incbin 
- 0010 22696e63 62696e2e 73220a20 2e696e63  "incbin.s". .inc
- 0020 62696e20 22696e63 62696e2e 73222c30  bin "incbin.s",0
- 0030 2c32380a 202e696e 6362696e 2022696e  ,28. .incbin "in
- 0040 6362696e 2e73222c 31352c39 0a202e70  cbin.s",15,9. .p
- 0050 32616c69 676e2034 0a202e64 6174610a  2align 4. .data.
- 0060 202e696e 6362696e 2022696e 6362696e   .incbin "incbin
- 0070 2e73220a 20202269 6e636269 6e2e0000  .s".  "incbin...
+Contents of section .text:
+ 0000 38383838 38383838 0c313232 3333330c  88888888.122333.
+ 0010 534f4d45 4d4f5245 44415441 44415441  SOMEMOREDATADATA
+ 0020 38383838 38383838 0c313232 3333330c  88888888.122333.
+ 0030 534f4d45 4d4f5245 44415441 44415441  SOMEMOREDATADATA
Index: incbin.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/all/incbin.s,v
retrieving revision 1.2
diff -u -p -r1.2 incbin.s
--- incbin.s	2001/12/08 00:25:26	1.2
+++ incbin.s	2001/12/19 08:42:06
@@ -1,5 +1,5 @@
- .data
- .incbin "incbin.s"
- .incbin "incbin.s",0,28
- .incbin "incbin.s",15,9
- .p2align 4
+	.text
+	.incbin "incbin.dat"
+	.incbin "incbin.dat",0,8
+	.incbin "incbin.dat",8,8
+	.incbin "incbin.dat",16,16
-------------- next part --------------
A non-text attachment was scrubbed...
Name: incbin.dat
Type: video/mpeg
Size: 32 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20011219/d9f6ac60/attachment.mpeg>
More information about the Binutils mailing list