Home Original page

Please comment: A patch for elf32-i386.c

Alan Modra alan@linuxcare.com.au
Thu Feb 8 18:53:00 GMT 2001 
On Thu, 8 Feb 2001, H . J . Lu wrote:

> Alan, how can
> I use elf_i386_discard_copies to do that? Why is there
> 
>               if (h != NULL 
>                   && ELF32_R_TYPE (rel->r_info) == R_386_PC32)
> 
> for using the pcrel_relocs_copied field?

I think it's there mainly just to cut down the number of relocs that use
pcrel_relocs_copied.  I see no reason why you can't use
pcrel_relocs_copied for other relocs (I do exactly that in elf32-hppa.c),
but I suggest you only use it as necessary and rename the field to plain
"relocs_copied" to avoid confusion.  Just be carefull with the conditions
you add in elf_i386_discard_copies and elf_i386_relocate_section.  It's a
little tricky to get right.

Alan
-- 
Linuxcare.  Support for the Revolution.
More information about the Binutils mailing list