Home Original page

PATCH: Enable PIC for mips*-*-*

H . J . Lu hjl@lucon.org
Thu Nov 8 06:58:00 GMT 2001 
On Sat, Nov 17, 2001 at 02:04:34AM -0200, Alexandre Oliva wrote:
> On Nov 17, 2001, "H . J . Lu" <hjl@lucon.org> wrote:
> 
> > Here is my patch:
> 
> >  # This must be Linux ELF.
> >  linux-gnu*)
> > -  case $host_cpu in
> > -  alpha* | hppa* | i*86 | powerpc* | sparc* | ia64* )
> > -    lt_cv_deplibs_check_method=pass_all ;;
> > -  *)
> > -    # glibc up to 2.1.1 does not perform some relocations on ARM
> > -    lt_cv_deplibs_check_method=['file_magic ELF [0-9][0-9]*-bit [LM]SB (shared
> > object|dynamic lib )'] ;;
> > -  esac
> > +  lt_cv_deplibs_check_method=['file_magic ELF [0-9][0-9]*-bit [LM]SB (shared
> > object|dynamic lib )']
> >    lt_cv_file_magic_test_file=`echo /lib/libc.so* /lib/libc-*.so`
> >    ;;
> 
> > I removed
> 
> > # glibc up to 2.1.1 does not perform some relocations on ARM
> 
> > since all Linux use file_magic now.
> 
> Yup.  And then you add code to the file_magic branch in ltmain.sh to
> compensate the effect of what used to be pass_all, which was right,
> and which is why your patch was wrong.
> 
> What you want for mips is to add it to the first branch of the case,
> such that deplibs_check_method=pass_all for mips too, if this is
> indeed correct for mips.

That is not what I want. My patch applies ALL Linux. No Linux should
use pass_all at all.

> 
> >> and linking archives into shared libraries is wrong on a number of
> >> platforms, and the way to tell libtool about it is use a different
> >> setting in deplibs_check_method.
> 
> > Feel free to get it right. My Linux binutils works fine under Linux.
> 
> But it won't build correctly with --enable-shared on other platforms
> that don't accept PDC in shared libraries.
> 

That is not my problem :-).


H.J.
More information about the Binutils mailing list