Home Original page

Backing out bad warning fixes

Daniel Jacobowitz drow@mvista.com
Sun Feb 10 13:26:00 GMT 2002 
Ian, if I understood you correctly these should both be OK.  I remove
the strtoul declaration, and undo the prototyping of localtime.  OK?

The latter nags at me but I'll do the configury after the rest of the
problems I noted (none of which are especially important) happen to
vanish :)  We should note that binutils is not really expected to build
with no warnings.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Index: ld/ChangeLog
===================================================================
RCS file: /cvs/src/src/ld/ChangeLog,v
retrieving revision 1.597
diff -u -p -r1.597 ChangeLog
--- ld/ChangeLog	2002/02/10 19:12:13	1.597
+++ ld/ChangeLog	2002/02/10 21:20:08
@@ -1,5 +1,9 @@
 2002-02-10  Daniel Jacobowitz  <drow@mvista.com>
 
+	* lexsup.c: Remove strtoul declaration.
+
+2002-02-10  Daniel Jacobowitz  <drow@mvista.com>
+
 	* ldmain.c: Add prototype for main ().
 	* lexsup.c: Guard declaration of strtoul with HAVE_STDLIB_H.
 	* emultempl/lnk960.em (lnk960_choose_target): Function should
Index: ld/lexsup.c
===================================================================
RCS file: /cvs/src/src/ld/lexsup.c,v
retrieving revision 1.47
diff -u -p -r1.47 lexsup.c
--- ld/lexsup.c	2002/02/10 19:12:13	1.47
+++ ld/lexsup.c	2002/02/10 21:20:08
@@ -53,13 +53,6 @@ Software Foundation, 59 Temple Place - S
 #define	S_ISDIR(m) (((m) & S_IFMT) == S_IFDIR)
 #endif
 
-#ifndef HAVE_STDLIB_H
-/* If we have <stdlib.h>, assume it defines strtoul.  */
-/* Omit args to avoid the possibility of clashing with a system header
-   that might disagree about consts.  */
-unsigned long strtoul ();
-#endif
-
 static int is_num PARAMS ((const char *, int, int, int));
 static void set_default_dirlist PARAMS ((char *dirlist_ptr));
 static void set_section_start PARAMS ((char *sect, char *valstr));
Index: binutils/ChangeLog
===================================================================
RCS file: /cvs/src/src/binutils/ChangeLog,v
retrieving revision 1.420
diff -u -p -r1.420 ChangeLog
--- binutils/ChangeLog	2002/02/10 18:47:48	1.420
+++ binutils/ChangeLog	2002/02/10 21:20:08
@@ -1,5 +1,9 @@
 2002-02-10  Daniel Jacobowitz  <drow@mvista.com>
 
+	* nlmconv.c: Back out localtime PARAMS change.
+
+2002-02-10  Daniel Jacobowitz  <drow@mvista.com>
+
 	* coffdump.c: Include "getopt.h" after "bucomm.h"
 	so that macros are defined correctly.
 	* nlmconv.c: Add PARAMS ((const time_t *)) to localtime
Index: binutils/nlmconv.c
===================================================================
RCS file: /cvs/src/src/binutils/nlmconv.c,v
retrieving revision 1.10
diff -u -p -r1.10 nlmconv.c
--- binutils/nlmconv.c	2002/02/10 18:47:48	1.10
+++ binutils/nlmconv.c	2002/02/10 21:20:08
@@ -59,7 +59,7 @@
 extern char *strerror PARAMS ((int));
 
 #ifndef localtime
-extern struct tm *localtime PARAMS ((const time_t *));
+extern struct tm *localtime ();
 #endif
 
 #ifndef SEEK_SET
More information about the Binutils mailing list