Home Original page

[PATCH RFA] add MIPS movn.ps, movz.ps, and tweak pref.

cgd@broadcom.com cgd@broadcom.com
Wed Mar 6 12:30:00 GMT 2002 
At 06 Mar 2002 12:20:47 -0800, Eric Christopher wrote:
> > ===================================================================
> > [opcodes/ChangeLog]
> > 2002-03-06  Chris Demetriou  <cgd@broadcom.com>
> > 
> > 	* mips-opc.c (mips_builtin_opcodes): Mark "pref" as being
> > 	present on I4.
> > 
> > 	* mips-opc.c (mips_builtin_opcodes): Add "movn.ps" and "movz.ps".
> > 
> 
> Should be one entry in the ChangeLog right?

So, I've seen statements like, if they're unrelated changes they
should get different entries.  And, this seems to be backed up by some
existing ChangeLog practice.  (e.g. look at 2001-08-25's change by
aj@suse.de, for a change which uses this style and has the same file
listed in multiple of the entries.)

The ChangeLog style info in the GNU coding standards say:

> Separate unrelated change log entries with blank lines. When two
> entries represent parts of the same change, so that they work
> together, then don't put blank lines between them. Then you can omit
> the file name and the asterisk when successive entries are in the
> same file.

(http://www.gnu.org/prep/standards_42.html)

My thought is that, even while these are going from the same patch and
with the same commit, they are in fact not 'related' changes since
they are independent of each other.

(Based on at least some existing ChangeLog entries, this seems like
the right metric to use.)


Anyway, checked in (with changelog as i posted; if everybody agrees
that's wrong, well, we can always fix it 8-).


chris
More information about the Binutils mailing list