Home Original page

[Patch] sh64: Fix gas testsuite expected output

Stephen Clarke stephen.clarke@earthling.net
Wed Oct 9 13:34:00 GMT 2002 
From: "Hans-Peter Nilsson"
Subject: Re: [Patch] sh64: Fix gas testsuite expected output


> Index: ld/testsuite/ld-sh/sh.exp
> ===================================================================
> RCS file: /cvs/src/src/ld/testsuite/ld-sh/sh.exp,v
> retrieving revision 1.8
> diff -u -c -3 -p -r1.8 sh.exp
> *** ld/testsuite/ld-sh/sh.exp   8 Feb 2002 06:49:55 -0000
> 1.8
> --- ld/testsuite/ld-sh/sh.exp   30 Aug 2002 00:51:57 -0000
> *************** if ![istarget sh*-*-*] {
> *** 25,31 ****
>       return
>   }
> 
> ! if [istarget sh64-*-elf] {
>       # relaxing not supported on sh64 yet.
>       return
>   }
> --- 25,32 ----
>       return
>   }
> 
> ! if { ([istarget sh64-*-elf]
> !       || [istarget sh64*-*-linux*])} {
>       # relaxing not supported on sh64 yet.
>       return
>   }
> 
> I'd rather you tweak the target specifiers on the tests:
> #targets: sh-*-* shl*-*-* shb*-*-*
> in each *.d should suffice.

It turns out that only ld-r-1.d matches
the sh64*-*-linux* target - none of the other *.d match
any linux configuration.

But I'm a bit nervous about the exact change you suggest,
because I thought sh[1234]-linux were supported
targets?

How about the following instead:
Index: ld-r-1.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-sh/ld-r-1.d,v
retrieving revision 1.3
diff -c -3 -p -r1.3 ld-r-1.d
*** ld-r-1.d 24 Feb 2002 16:44:44 -0000 1.3
--- ld-r-1.d 9 Oct 2002 20:28:27 -0000
***************
*** 4,9 ****
--- 4,10 ----
  #ld: -r -EL
  #readelf: -r -x1 -x2
  #target: sh*-*-elf sh*-*-linux*
+ #notarget: sh64*-*-linux*
  
  # Make sure relocations against global and local symbols with relative and
  # absolute 32-bit relocs don't come out wrong after ld -r.  Remember that




__________________________________________________
Do you Yahoo!?
Faith Hill - Exclusive Performances, Videos & More
http://faith.yahoo.com
More information about the Binutils mailing list