Home Original page

sh GAS testsuite fixes

Nick Clifton nickc@redhat.com
Mon Dec 22 10:02:00 GMT 2003 
Hi Guys,

  This recent patch:
  
  2003-12-02  Alexandre Oliva  <aoliva@redhat.com>

	* sh-opc.h: Add support for sh4a and no-fpu variants.
	* sh-dis.c: Ditto.

  changed the spelling of the 'FSSRA' opcode which broke several of
  the SH GAS testsuite entries.  The patch below fixes this, along
  with the a small bug in the decoded values of a couple of the DSP
  instructions.

  With this patch applied sh-elf type targets now have no gas
  testsuite failures.  (The sh-hms target still has a few failures but
  I will look at them another day).

Cheers
        Nick
        
gas/testsuite/ChangeLog  
2003-12-22  Nick Clifton  <nickc@redhat.com>

	* gas/sh/err-sh4a-fp.s: Fix spelling of opcode fssra.
	* gas/sh/err-sh4a-fp.d: Likewise.
	* gas/sh/sh4a-fp.s: Likewise.
	* gas/sh/sh4al-dsp.d: Fix expected opcode values for a couple of
	instructions.	

Index: gas/testsuite/gas/sh/err-sh4a-fp.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/sh/err-sh4a-fp.s,v
retrieving revision 1.1
diff -c -3 -p -r1.1 err-sh4a-fp.s
*** gas/testsuite/gas/sh/err-sh4a-fp.s	5 Dec 2003 01:59:54 -0000	1.1
--- gas/testsuite/gas/sh/err-sh4a-fp.s	22 Dec 2003 08:52:44 -0000
***************
*** 5,14 ****
  
  	fpchg	fpul		! { dg-error "excess operands" }
  
! 	fsrra	fr1, fr2	! { dg-error "excess operands" }
! 	fsrra			! { dg-error "invalid operands|missing operand" }
! 	fsrra	fpul		! { dg-error "invalid operands" }
! 	fsrra	dr0, dr2	! { dg-error "invalid operands" }
  
  	fsca	dr0, fpul	! { dg-error "invalid operands" }
  	fsca	fpul, fr0	! { dg-error "invalid operands" }
--- 5,14 ----
  
  	fpchg	fpul		! { dg-error "excess operands" }
  
! 	fssra	fr1, fr2	! { dg-error "excess operands" }
! 	fssra			! { dg-error "invalid operands|missing operand" }
! 	fssra	fpul		! { dg-error "invalid operands" }
! 	fssra	dr0, dr2	! { dg-error "invalid operands" }
  
  	fsca	dr0, fpul	! { dg-error "invalid operands" }
  	fsca	fpul, fr0	! { dg-error "invalid operands" }
Index: gas/testsuite/gas/sh/sh4a-fp.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/sh/sh4a-fp.d,v
retrieving revision 1.1
diff -c -3 -p -r1.1 sh4a-fp.d
*** gas/testsuite/gas/sh/sh4a-fp.d	5 Dec 2003 01:59:54 -0000	1.1
--- gas/testsuite/gas/sh/sh4a-fp.d	22 Dec 2003 08:52:44 -0000
*************** start address 0x00000000
*** 8,15 ****
  
  Disassembly of section \.text:
  0x00000000 f7 fd       	fpchg	
! 0x00000002 f1 7d       	fsrra	fr1
! 0x00000004 f9 7d       	fsrra	fr9
! 0x00000006 f6 7d       	fsrra	fr6
  0x00000008 f2 fd       	fsca	fpul,dr2
  0x0000000a fc fd       	fsca	fpul,dr12
--- 8,15 ----
  
  Disassembly of section \.text:
  0x00000000 f7 fd       	fpchg	
! 0x00000002 f1 7d       	fssra	fr1
! 0x00000004 f9 7d       	fssra	fr9
! 0x00000006 f6 7d       	fssra	fr6
  0x00000008 f2 fd       	fsca	fpul,dr2
  0x0000000a fc fd       	fsca	fpul,dr12
Index: gas/testsuite/gas/sh/sh4a-fp.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/sh/sh4a-fp.s,v
retrieving revision 1.1
diff -c -3 -p -r1.1 sh4a-fp.s
*** gas/testsuite/gas/sh/sh4a-fp.s	5 Dec 2003 01:59:54 -0000	1.1
--- gas/testsuite/gas/sh/sh4a-fp.s	22 Dec 2003 08:52:44 -0000
***************
*** 3,11 ****
  
  	fpchg
  
! 	fsrra fr1
! 	fsrra fr9
! 	fsrra fr6
  
  	fsca fpul, dr2
  	fsca fpul, dr12
--- 3,11 ----
  
  	fpchg
  
! 	fssra fr1
! 	fssra fr9
! 	fssra fr6
  
  	fsca fpul, dr2
  	fsca fpul, dr12
Index: gas/testsuite/gas/sh/sh4al-dsp.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/sh/sh4al-dsp.d,v
retrieving revision 1.1
diff -c -3 -p -r1.1 sh4al-dsp.d
*** gas/testsuite/gas/sh/sh4al-dsp.d	5 Dec 2003 01:59:54 -0000	1.1
--- gas/testsuite/gas/sh/sh4al-dsp.d	22 Dec 2003 08:52:44 -0000
*************** start address 0x00000000
*** 10,19 ****
  Disassembly of section \.text:
  0x00000000 43 34       	ldrc	r3
  0x00000002 4c 34       	ldrc	r12
! 0x00000004 8c 0a       	ldrc	#10
! 0x00000006 8c f3       	ldrc	#-13
! 0x00000008 00 c8       	setdmx	
! 0x0000000a 00 98       	setdmy	
  0x0000000c 00 88       	clrdmxy	
  
  0x0000000e f1 16       	movx\.w	@r4,x0	movy\.w	a0,@r7\+
--- 10,19 ----
  Disassembly of section \.text:
  0x00000000 43 34       	ldrc	r3
  0x00000002 4c 34       	ldrc	r12
! 0x00000004 8a 0a       	ldrc	#10
! 0x00000006 8a f3       	ldrc	#-13
! 0x00000008 00 98       	setdmx	
! 0x0000000a 00 c8       	setdmy	
  0x0000000c 00 88       	clrdmxy	
  
  0x0000000e f1 16       	movx\.w	@r4,x0	movy\.w	a0,@r7\+
More information about the Binutils mailing list