Home Original page

[rfa] make bfd_set_section_contents buffer param constant

Alan Modra amodra@bigpond.net.au
Sat Nov 1 01:57:00 GMT 2003 
On Fri, Oct 31, 2003 at 12:22:10PM -0500, Andrew Cagney wrote:
> 	* section.c (bfd_set_section_contents): Make the "location" buffer
> 	constant.
> 	* bfd-in2.h: Re-generate.

OK.  Andrew, if you're in cleanup mode can I suggest another worthwhile
cleanup?  A bit more work than this one.

In bfd we have a number of places that use a bfd_vma to store/pass data
known to require 64 bit integer types.  We ought to use an explicit 64
bit type, as bfd_vma is only 32 bits when configuring for a 32 bit
target (unless you use --enable-64-bit-bfd, which bloats libbfd).  One
example of a place that would benefit is dwarf2.c, where we run into an
assert if processing DW_FORM_data8.  I can't see anything in the DWARF3
spec that precludes use of data8 and ref8 in a 32 bit ELF file.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre
More information about the Binutils mailing list