Home Original page

PATCH: Update libiberty/testsuite/demangle-expected

H. J. Lu hjl@lucon.org
Fri Oct 17 04:08:00 GMT 2003 
I assumed the output of demanglers in libiberty and libstdc++ should
be the identical on the same C++ symbol. I copied that particular test
from libstdc++. Since the orginal test was changed, I thought I should
keep it in sync. I guess my assumption is wrong. What is the policy on
the outputs from demanglers between libiberty and libstdc++ on the same
C++ symbols?

H.J.
---
On Thu, Oct 16, 2003 at 06:46:20PM -0400, DJ Delorie wrote:
> 
> > This patch syncs libiberty/testsuite/demangle-expected with
> > 
> > http://gcc.gnu.org/ml/gcc-patches/2003-09/msg02161.html
> > 
> > OK to install?
> 
> I don't see anywhere that someone approved this patch, yet I noticed
> that you committed it anyway.  That is NOT the proper procedure,
> especially in this case where the testsuite is a testsuite for the
> demangler in libiberty, not the demangler in libstdc++, so this patch
> is incorrect without justification in the context of libiberty's
> demangler.
> 
> There are NO obvious changes to the testsuite, ever.
> 
> In the future, please assume that you do NOT have the priviledge of
> checking in libiberty patches, obvious or otherwise, without explicit
> approval.
More information about the Binutils mailing list