Alan Modra amodra@bigpond.net.au
Sat May 15 02:13:00 GMT 2004

• Previous message (by thread): PATCH: Support mixing COMDAT and linkonce
• Next message (by thread): PATCH: Support mixing COMDAT and linkonce
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

On Fri, May 14, 2004 at 02:07:37PM -0700, H. J. Lu wrote:
> When there are mixed COMDAT and linkonce inputs, linker doesn't handle
> them gracefully:

Ewww.  Should we even try?  I understand that such a patch might be
useful while gcc is emitting both comdat and linkonce, but once you've
completed the change to comdat it shouldn't be necessary.  Also, I'm not
really happy with where you have added this code.  At least, it is the
wrong place to be discarding duplicate sections.  That ought to happen
in ldlang.c:section_already_linked.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

---

• Previous message (by thread): PATCH: Support mixing COMDAT and linkonce
• Next message (by thread): PATCH: Support mixing COMDAT and linkonce
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list