PATCH: PR 757: Linker fails to set correct alignment for common symbol

Nick Clifton nickc@redhat.com
Mon Feb 28 18:01:00 GMT 2005
Hi H. J.

> 2005-02-22  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	PR 757
> 	* elf-bfd.h (_bfd_elf_merge_symbol): Add a pointer to unsigned
> 	int.
> 
> 	* elf32-sh-symbian.c (sh_symbian_relocate_section): Pass NULL
> 	to _bfd_elf_merge_symbol.
> 
> 	* elflink.c (_bfd_elf_merge_symbol): Use the pointer to
> 	unsigned int to return the alignment of the old common symbol
> 	in the dynamic object.
> 	(_bfd_elf_add_default_symbol): Pass NULL to
> 	_bfd_elf_merge_symbol.
> 	(elf_link_add_object_symbols): Pass &old_alignment to
> 	_bfd_elf_merge_symbol. Get the alignment of the new common
> 	symbol in the dynamic object.

Have you tested this patch ?  If so, and if it has not introduced any 
regressions, then please consider it approved.

Cheers
   Nick




More information about the Binutils mailing list