Home Original page

[RFA/hpux] Implement file_matches_executable_p

Daniel Jacobowitz drow@false.org
Thu Nov 17 04:26:00 GMT 2005 
On Wed, Nov 16, 2005 at 05:14:31PM -0800, Joel Brobecker wrote:
> > 
> > Yes; more generally (a) you can define the relevant method directly to
> > the generic function, no need to wrap it, and (b) might as well call it
> > from every currently stubbed out implementation of this function and
> > get them all at once.
> 
> The attached patch should be better. The only part I wasn't sure about
> is regarding the stubbed out implementations. How to I find them?

Very simple: you grep for file_matches_executable_p :-)  If anyone
didn't give theirs the obvious name, well, too bad for them.

> @@ -433,7 +416,9 @@ const bfd_target hpux_core_vec =
>  
>      BFD_JUMP_TABLE_GENERIC (_bfd_generic),
>      BFD_JUMP_TABLE_COPY (_bfd_generic),
> -    BFD_JUMP_TABLE_CORE (hpux_core),
> +    hpux_core_core_file_failing_command,
> +    hpux_core_core_file_failing_signal,
> +    generic_core_file_matches_executable_p,
>      BFD_JUMP_TABLE_ARCHIVE (_bfd_noarchive),
>      BFD_JUMP_TABLE_SYMBOLS (_bfd_nosymbols),
>      BFD_JUMP_TABLE_RELOCS (_bfd_norelocs),

You can just do this instead:
#define hpux_core_file_matches_executable_p generic_core_file_matches_executable_p

-- 
Daniel Jacobowitz
CodeSourcery, LLC
More information about the Binutils mailing list