Home Original page

[RFA/hpux] Implement file_matches_executable_p

Joel Brobecker brobecker@adacore.com
Fri Nov 18 01:14:00 GMT 2005 
> Now, on to the other maches_executable_p function bodies...

One question: I've seen two instances of the following case:

    char *
    cisco_core_file_failing_command (abfd)
         bfd *abfd ATTRIBUTE_UNUSED;
    {
      return NULL;
    }
    
    int
    cisco_core_file_failing_signal (abfd)
         bfd *abfd ATTRIBUTE_UNUSED;
    {
      return abfd->tdata.cisco_core_data->sig;
    }
    
    bfd_boolean
    cisco_core_file_matches_executable_p (core_bfd, exec_bfd)
         bfd *core_bfd ATTRIBUTE_UNUSED;
         bfd *exec_bfd ATTRIBUTE_UNUSED;
    {
      return TRUE;
    }

I can remove the target specific core_file_matches_executable_p,
and replace it with the generic one. It is a bit less efficient
though. Should I proceed with the replacement anyway?

-- 
Joel
More information about the Binutils mailing list