Nick Clifton nickc@redhat.com
Mon Mar 6 16:11:00 GMT 2006

• Previous message (by thread): [m68k] arch flag cleanup v2
• Next message (by thread): Add support for ld-elf.so.hints on FreeBSD - Third try
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi Diego,

> New version of the two patches to add support for ld hints on FreeBSD (and 
> DragonFly). 


The patch is basically OK, but...

   1. It is missing a ChangeLog entry.

   2. Formatting - please follow the GNU Coding Convention:

> +/*
> + * Read the system search path the FreeBSD way rather than like Linux.
> + */

   should be:

   /* Read the system search path the FreeBSD way rather then like 
Linux.  */


> +	  if (fread(&hdr, 1, sizeof(hdr), f) == sizeof(hdr) &&

   should be:


    if (fread (&hdr, 1, sizeof (hdr), f) == sizeof (hdr)
        && .....


   3. License information:

> +  * Fallback code taken from FreeBSD's libc
> +  * Copyright (c) 1997 John D. Polstra.

      Under what form(s) of license is this code distributed ?  Is 
it/are they compatible with the GPL ?  Why have they not been included 
here ?


   4. What is this elf-hints.h file ?  Shouldn't it be provided with the 
patch ?

Cheers
   Nick

---

• Previous message (by thread): [m68k] arch flag cleanup v2
• Next message (by thread): Add support for ld-elf.so.hints on FreeBSD - Third try
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list