Home Original page

The gas input processing changes caused a regression for cris-elf

Alexandre Oliva aoliva@redhat.com
Fri Mar 9 18:16:00 GMT 2007 
On Mar  9, 2007, Hans-Peter Nilsson <hans-peter.nilsson@axis.com> wrote:

> Hi Alex, looks like another good deed of yours being punished: :-)

:-)

I guess I should have been far more conservative in my patch, since
regular comments might very well look like # <line> lines, and by the
time we realize they're not, we're already committed to that parsing.

Here's a patch that removes one more state from the state machine,
accepts comments that appear to be #line"file" directives with at most
warnings about unsupported flag numbers.  I might be talked into
taking even those out.

A cross to cris-elf now passes the gas testsuite.

Ok to install?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gas-linefile-comment.patch
Type: text/x-patch
Size: 3723 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20070309/76ef0afd/attachment.bin>
-------------- next part --------------

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
FSF Latin America Board Member         http://www.fsfla.org/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}
More information about the Binutils mailing list