Nick Clifton nickc@redhat.com
Tue Jul 8 08:26:00 GMT 2008

• Previous message (by thread): [PATCH] Allow MIPS16 symbols to have nondefault visiblity
• Next message (by thread): [PATCH] Let more MIPS relocs refer to __gnu_local_gp
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

Hi Richard,

>> Wouldn't it make more sense to use STO_MIPS16 instead of 0xf0 in these 
>> new macros ?  ie:
>>
>>    #define ELF_ST_IS_MIPS16(OTHER) (((OTHER) & STO_MIPS16) == STO_MIPS16)
> 
> Ah, sorry, I should have mentioned that.  This ties in with later patches,
> which treated the top four bits of st_other as an enum.  It looks like
> we might still be doing that for any future STO_MIPS_PIC flag.
> 
> Stepping back, the problem is that STO_MIPS16 rather rudely takes up
> half of st_other, and we currently need one or two more STO_* values.
> It would be good to put mutually-exclusive STO_* values in the same bits.
> 
> I couldn't think of a good name for the enum, so I didn't introduce
> a mnemonic for it...

No worries.  Thanks for the explanation and please consider the patch 
approved.

Cheers
   Nick

---

• Previous message (by thread): [PATCH] Allow MIPS16 symbols to have nondefault visiblity
• Next message (by thread): [PATCH] Let more MIPS relocs refer to __gnu_local_gp
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

---

More information about the Binutils mailing list