Home Original page

[patch]: Correct interpretation of IMAGE_SCN_MEM_DISCARDABLE in coffcode.h

Nick Clifton nickc@redhat.com
Fri Jan 16 10:23:00 GMT 2009 
Hi Kai,

> Thank you for giving me a hint. I altered the patch, so that it sets 
> DEBUGGING for .debug*, .stab*, .comment, and .gnu.linkonce.wi.* sections.
> 
> Ok, for apply?

Approved - please apply; except - please could you adjust the wording of 
the comment slightly.  Instead of:

   /* The MS PE spec says, that debug sections are DISCARDABLE,
      but the DISCARDABLE flag has not the meaning of being debug.
      So just set SEC_DEBUGGING for them.  */

please could we have:

   /* The MS PE spec says that debug sections are DISCARDABLE,
      but the presence of a DISCARDABLE flag does not necessarily
      mean that a given section contains debug information.  Thus
      we only set the SEC_DEBUGGING flag on sections that we
      recognise as containing debug information.  */

Cheers
   Nick
More information about the Binutils mailing list